[BT-4418] FaunaParser Double values #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchitolina-fauna
changed the title
pchitolina-fauna
changed the base branch from
dev
to
feature/BT-4418-utf8faunareader_read_int
pchitolina-fauna
changed the base branch from
feature/BT-4418-utf8faunareader_read_int
to
feature/BT-4418-utf8faunareader_read_date_and_time
…o feature/BT-4418-utf8faunareader_read_double # Conflicts: # faunaJava/src/test/java/com/fauna/serialization/FaunaParserTest.java
pchitolina-fauna
changed the title
pnwpedro
requested changes
Jan 29, 2024
faunaJava/src/main/java/com/fauna/serialization/FaunaParser.java
Outdated
Show resolved
Hide resolved
…o feature/BT-4418-utf8faunareader_read_double # Conflicts: # faunaJava/src/test/java/com/fauna/serialization/FaunaParserTest.java
pnwpedro
requested changes
Jan 30, 2024
faunaJava/src/main/java/com/fauna/serialization/FaunaParser.java
Outdated
Show resolved
Hide resolved
faunaJava/src/test/java/com/fauna/serialization/FaunaParserTest.java
Outdated
Show resolved
Hide resolved
pnwpedro
changed the base branch from
feature/BT-4418-utf8faunareader_read_date_and_time
to
dev
…t.java Co-authored-by: Lucas Pedroza <[email protected]>
Co-authored-by: Lucas Pedroza <[email protected]>
pnwpedro
requested changes
Jan 31, 2024
faunaJava/src/test/java/com/fauna/serialization/FaunaParserTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
168
to
176
| String invalidJson = "{\"@double\": \"abc\"}"; | ||
| InputStream invalidInputStream = new ByteArrayInputStream(invalidJson.getBytes()); | ||
| FaunaParser invalidReader = new FaunaParser(invalidInputStream); | ||
|
|
||
| expectedTokens = List.of( | ||
| Map.entry(FaunaTokenType.DOUBLE, "abc") | ||
| ); | ||
|
|
||
| assertReader(invalidReader, expectedTokens, true); |
There was a problem hiding this comment.
This should be a separate test.
pnwpedro
approved these changes
Jan 31, 2024
pchitolina-fauna
deleted the
feature/BT-4418-utf8faunareader_read_double
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): BT-4418
Merge after: #18
Problem
The current Fauna serialization module lacks a dedicated method to read values as Double.
Solution
Implemented specific logic for handling Fauna-specific token as Double.
Result
The addition of this capability enables the extraction and reading of tokens as Double, enhancing the functionality of the Fauna serialization module.
Testing
Run
Utf8FaunaReaderTest.javaBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.