Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkstyle issues in com.fauna.codec #181

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

pnwpedro
Copy link
Collaborator

Description

Add javadocs and fix other checkstyle issues in com.fauna.codec

Motivation and context

BT-5258

How was the change tested?

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pnwpedro pnwpedro requested a review from jrodewig November 12, 2024 15:06
@jrodewig jrodewig force-pushed the com.fauna.codec-javadocs branch from 9a73c93 to 64d2c73 Compare November 12, 2024 15:31
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed some minor changes in 64d2c73 (#181).

@pnwpedro pnwpedro merged commit 77b1727 into main Nov 12, 2024
1 check passed
@pnwpedro pnwpedro deleted the com.fauna.codec-javadocs branch November 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants