Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stats collector #160

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Use stats collector #160

merged 2 commits into from
Oct 29, 2024

Conversation

pnwpedro
Copy link
Collaborator

Description

Motivation and context

BT-4971

  • Some users want to track query stats (like read/write/compute ops) at the top level
  • In the case of pagination, there's no way to track stats on the individual requests

How was the change tested?

  • Integration tests for streams, pagination, and queries

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pnwpedro pnwpedro changed the base branch from main to stats-collector-impl October 28, 2024 11:07
@pnwpedro pnwpedro requested a review from findgriffin October 28, 2024 11:07
@pnwpedro pnwpedro force-pushed the use-stats-collector branch from c861aad to 5b8578a Compare October 28, 2024 12:37
Copy link
Contributor

@cynicaljoy cynicaljoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just the minor java doc correction

src/main/java/com/fauna/client/FaunaConfig.java Outdated Show resolved Hide resolved
@pnwpedro pnwpedro force-pushed the use-stats-collector branch from 5b8578a to 5699da2 Compare October 29, 2024 13:34
jdcryans
jdcryans previously approved these changes Oct 29, 2024
Base automatically changed from stats-collector-impl to main October 29, 2024 15:01
@pnwpedro pnwpedro dismissed jdcryans’s stale review October 29, 2024 15:01

The base branch was changed.

Copy link

@jdcryans jdcryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@pnwpedro pnwpedro merged commit e48ef8b into main Oct 29, 2024
1 check passed
@pnwpedro pnwpedro deleted the use-stats-collector branch October 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants