fix: retain feed page size #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickpintor
approved these changes
Jan 7, 2025
Currently when getting the next page of a feed, we clear the page size that it was created with. This means that if I start a feed with page size 1000, after that my subsequent pages will drop to the default page size of 16. This change makes it such that the page size will stay consistent.
fauna-chase
force-pushed
the
retain-feed-page-size
branch
from
aa8dadc to
11f8234
Compare
cynicaljoy
approved these changes
Jan 8, 2025
Co-authored-by: Darren Cunningham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when getting the next page of a feed, we clear the page size that it was created with. This means that if I start a feed with page size 1000, after that my subsequent pages will drop to the default page size of 16. This change makes it such that the page size will stay consistent.
I currently tested this in a qa environment where I am running change feeds to see how many events per second I can consume. I will add a test to this once I verify this is the behavior we want.