feat: Event Stream refactor #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cynicaljoy
requested review from
jdcryans,
findgriffin,
erickpintor and
adambollen
Merged
cynicaljoy
commented
Oct 23, 2024
cynicaljoy
force-pushed
the
refactor-stream
branch
from
e4eea78 to
a8f11e6
Compare
jrodewig
reviewed
Oct 25, 2024
pnwpedro
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
This lgtm, but don't we have to increment to v3 everywhere before we make these changes? https://github.com/search?q=repo:fauna/fauna-go%20v2&type=code
my plan was to merge this to main and then version bump in a separate PR. do you think we should version bump within this one? |
cynicaljoy
force-pushed
the
refactor-stream
branch
from
b6c9ffb to
93148b4
Compare
yeah, i was thinking we'd move to v3 before. we can always cherry pick something to v2 and adjust the pipeline to deploy it if needed. |
jrodewig
approved these changes
Oct 25, 2024
cynicaljoy
force-pushed
the
refactor-stream
branch
from
c5ff934 to
119944b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-6824
Description
Rename the Event Stream resources
Motivation and context
Consistent naming between the Features and the drivers
How was the change tested?
Unit/Integration tests
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.