Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added initial backoff retry impementation #37

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Added initial backoff retry impementation #37

merged 1 commit into from
Dec 27, 2023

Conversation

andrii-otroshko-forte
Copy link
Contributor

Added initial implementation of retry mechanism for handling transient failures (specifically HTTP 429 responses):

  • Converted ClientConfig from a class to a record to enhance immutability and predictability
  • Added MaxRetries and MaxBackoff in Connection for configurable retry policies
  • Implemented exponential backoff for HTTP 429 responses
  • Updated Client class to use new retry settings

pnwpedro
pnwpedro approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@pnwpedro pnwpedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrii-otroshko-forte andrii-otroshko-forte merged commit 791128a into initial_error_handling Dec 27, 2023
4 checks passed
@andrii-otroshko-forte andrii-otroshko-forte deleted the backoff_retry branch December 27, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnwpedro pnwpedro pnwpedro approved these changes

@adambollen adambollen Awaiting requested review from adambollen

@freels freels Awaiting requested review from freels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrii-otroshko-forte @pnwpedro @aotroshko