[DOCS-3571] README: Update for staged schema default #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
force-pushed
the
staged-schema-default
branch
from
5e3c3cc to
8373ed7
Compare
jrodewig
force-pushed
the
staged-schema-default
branch
from
8373ed7 to
d5fc1ec
Compare
macmv
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
looks good to me. i'd actually recommend staging the schema, but to keep the behavior the same, this looks good to me.
if people aren't using the latest shell, this won't work though. so maybe worth a small note saying "make sure you're on at least shell version 3"
jrodewig
changed the title
jrodewig
changed the title
macmv
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge until the
fauna-shellrelease.Problem
The upcoming fauna-shell release will stage schema changes by default.
See fauna/fauna-shell#387.
Solution
Updates the README to push an unstaged schema change.