[ROAD 534] Add state to stories #309
Conversation
|
@arielj Addressed your comments |
…pproved-attribute-to-stories
|
After merging, we have to run |
app/views/stories/_form.html.erb
Outdated
| <div class="field story_status"> | ||
| <%= f.label :status, "Status" %> | ||
| <%= f.select :status, options_for_select({ "Pending" => "pending", "Approved" => "approved", "Rejected" => "rejected" }, selected: @story.status), class: "project-story-approved" %> | ||
| </div> |
There was a problem hiding this comment.
With the new status field, this seems a little bit moved, I expected the preview to be aligned with the description field at least as it was before.
The first thing I want to write is the story's title. can we move the status field after the extra info?
All of this is purely personal opinion. so, if somebody else can comment about it would be nice.
There was a problem hiding this comment.
So, I moved the status selector, but I noticed that the description preview is actually in the right place, according to the scss and the app version currently in production.
Co-authored-by: Juan Vásquez <[email protected]>
There was a problem hiding this comment.
I left a comment but I'll approve it since I've been so annoying. @mateusdeap Thanks!
| @@ -1,2 +1,18 @@ | |||
| module StoriesHelper | |||
| def status_label(story) | |||
| "<span class='story-status-badge #{story.status}'>#{story.status}</span>".html_safe | |||
There was a problem hiding this comment.
I'd like to see the first letter as uppercase equal as we see it in the select field.
There was a problem hiding this comment.
I think I'm going to skip this one since I think labels are better in lowercase but, mainly, because when I started to change this, I noticed I'd have to edit quite a few specs and a bit of JS that was swapping css classes based on the text content of the label.
Maybe add this as a bug or improvement story for later on?
|
@mateusdeap feel free to merge after addressing Juan's comment (if you feel it's worth it), but don't forget to run the migrations in heroku console :) |
Jira Ticket
ROAD-534
Motivation / Context
Fixes #196
This PR adds a new attribute to the story model, called
approved, which is a boolean and depending on wether it istrue,falseornilit represents 3 possible states to a story: Approved, Rejected or Pending.By default, all stories are created in the Pending state.
It is possible to define this state during story creation and edition.
Additionally, in the story show page, one can use a dropdown to change the state.
Finally, added labels in the project show page so we know at a glance which stories have been approved or not.
QA / Testing Instructions
Run the application via
rails sor docker and visit any project page containing stories in the stories list. You should see they are all pending.To change the state, click on any story and then click on the dropdown button near the story title and select one of the states in the dropdown.
Additionally, you can click to edit the story and select the state from a select box or, in the project's show page, if you click to add a new story, you should be able to select it's state via a select box as well.
Screenshots:
I will abide by the code of conduct.