ci: add test and lint jobs to ci

.editorconfig

@@ -10,3 +10,6 @@ insert_final_newline = true
 charset = utf-8
 indent_style = space
 indent_size = 4
+
+[*.{yml,yaml}]
+indent_size = 2

.gitlab-ci.yml

@@ -1,5 +1,20 @@
+before_script:
+  - npm ci --ignore-scripts --force
+
+build:
+  stage: build
+  script: npm run build
+  only:
+    - merge_requests
+
+lint:
+  stage: test
+  script: npm run lint
+  only:
+    - merge_requests
+
 test:
   stage: test
-  script: npm ci --ignore-scripts --force && npm run test
+  script: npm run test
   only:
     - merge_requests

dist/squire-raw.js

@@ -338,11 +338,13 @@
       if (!child || isLeaf(child)) {
         if (startOffset) {
           child = startContainer.childNodes[startOffset - 1];
-          let prev = child.previousSibling;
-          while (child instanceof Text && !child.length && prev && prev instanceof Text) {
-            child.remove();
-            child = prev;
-            continue;
+          const prev = child.previousSibling;
+          if (prev && prev instanceof Text) {
+            while (child instanceof Text && !child.length) {
+              child.remove();
+              child = prev;
+              continue;
+            }
           }
           if (child instanceof Text) {
             startContainer = child;
@@ -466,18 +468,14 @@
     return node;
   };
   var fixContainer = (container, root) => {
-    const children = container.childNodes;
     let wrapper = null;
-    for (let i = 0, l = children.length; i < l; i += 1) {
-      const child = children[i];
+    [...container.childNodes].forEach((child) => {
       const isBR = child.nodeName === "BR";
       if (!isBR && isInline(child)) {
         if (!wrapper) {
           wrapper = createElement("DIV");
         }
         wrapper.appendChild(child);
-        i -= 1;
-        l -= 1;
       } else if (isBR || wrapper) {
         if (!wrapper) {
           wrapper = createElement("DIV");
@@ -487,15 +485,13 @@
           container.replaceChild(wrapper, child);
         } else {
           container.insertBefore(wrapper, child);
-          i += 1;
-          l += 1;
         }
         wrapper = null;
       }
       if (isContainer(child)) {
         fixContainer(child, root);
       }
-    }
+    });
     if (wrapper) {
       container.appendChild(fixCursor(wrapper));
     }

dist/squire-raw.mjs

@@ -340,11 +340,13 @@ var moveRangeBoundariesDownTree = (range) => {
     if (!child || isLeaf(child)) {
       if (startOffset) {
         child = startContainer.childNodes[startOffset - 1];
-        let prev = child.previousSibling;
-        while (child instanceof Text && !child.length && prev && prev instanceof Text) {
-          child.remove();
-          child = prev;
-          continue;
+        const prev = child.previousSibling;
+        if (prev && prev instanceof Text) {
+          while (child instanceof Text && !child.length) {
+            child.remove();
+            child = prev;
+            continue;
+          }
         }
         if (child instanceof Text) {
           startContainer = child;
@@ -468,18 +470,14 @@ var fixCursor = (node) => {
   return node;
 };
 var fixContainer = (container, root) => {
-  const children = container.childNodes;
   let wrapper = null;
-  for (let i = 0, l = children.length; i < l; i += 1) {
-    const child = children[i];
+  [...container.childNodes].forEach((child) => {
     const isBR = child.nodeName === "BR";
     if (!isBR && isInline(child)) {
       if (!wrapper) {
         wrapper = createElement("DIV");
       }
       wrapper.appendChild(child);
-      i -= 1;
-      l -= 1;
     } else if (isBR || wrapper) {
       if (!wrapper) {
         wrapper = createElement("DIV");
@@ -489,15 +487,13 @@ var fixContainer = (container, root) => {
         container.replaceChild(wrapper, child);
       } else {
         container.insertBefore(wrapper, child);
-        i += 1;
-        l += 1;
       }
       wrapper = null;
     }
     if (isContainer(child)) {
       fixContainer(child, root);
     }
-  }
+  });
   if (wrapper) {
     container.appendChild(fixCursor(wrapper));
   }

source/node/MergeSplit.ts

@@ -60,7 +60,7 @@ const fixContainer = (
     root: Element | DocumentFragment,
 ): Node => {
     let wrapper: HTMLElement | null = null;
-    [...container.childNodes].forEach(child => {
+    [...container.childNodes].forEach((child) => {
         const isBR = child.nodeName === 'BR';
         if (!isBR && isInline(child)) {
             if (!wrapper) {

source/range/Boundaries.ts

@@ -48,19 +48,17 @@ const moveRangeBoundariesDownTree = (range: Range): void => {
         if (!child || isLeaf(child)) {
             if (startOffset) {
                 child = startContainer.childNodes[startOffset - 1];
-                let prev = child.previousSibling;
+                const prev = child.previousSibling;
                 // If we have an empty text node next to another text node,
                 // just skip and remove it.
-                while (
-                    child instanceof Text &&
-                    !child.length &&
-                    prev &&
-                    prev instanceof Text
-                ) {
-                    child.remove();
-                    child = prev;
-                    continue;
+                if (prev && prev instanceof Text) {
+                    while (child instanceof Text && !child.length) {
+                        child.remove();
+                        child = prev;
+                        continue;
+                    }
                 }
+
                 if (child instanceof Text) {
                     startContainer = child;
                     startOffset = child.data.length;