Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for New Relic OTLP endpoint #785

Closed
wants to merge 3 commits into from

Conversation

mdenomy
Copy link
Contributor

@mdenomy mdenomy commented Dec 5, 2023

Adds support for the New Relic OTLP logging endpoint

@Integralist Integralist added the enhancement New feature or request label Dec 5, 2023
@Integralist
Copy link
Collaborator

Integralist commented Dec 5, 2023

👋🏻 Can you run make generate-docs locally, and commit the changes and push them up again.

I've given the @fastly/systems team (of which you are a member) WRITE access, which should mean the validate-interface CI job will run with access to the GitHub Secret token (your previous push failed that CI job because you were not recognised as a contributor and so you don't get access to the GitHub secrets).

@Integralist Integralist self-requested a review December 5, 2023 16:48
@mdenomy mdenomy force-pushed the mdenomy/log-1814-newrelic-otlp branch from d1dd391 to c8a71d3 Compare December 5, 2023 16:52
@mdenomy mdenomy force-pushed the mdenomy/log-1814-newrelic-otlp branch from f678a7d to c52825a Compare December 5, 2023 18:15
@Integralist
Copy link
Collaborator

@mdenomy My apologies but would it be possible (now I've given your GitHub team WRITE access) to close this PR and re-open it directly on this repo as a contributor with direct WRITE access (i.e. rather than opening a pull request via your fork of this repo)?

The reason being is that the validate-interface CI job (which is an important job as it helps identify potential breaking changes in the Terraform interface) needs access to an environment secret to run, but GitHub won't expose the secret when the workflow is run on a PR that's from a fork of the repo.

Apologies again, I appreciate it's a bit of a pain to have to ask this 😞

@mdenomy
Copy link
Contributor Author

mdenomy commented Dec 7, 2023

@Integralist not a problem at all, thanks for the help.

@mdenomy
Copy link
Contributor Author

mdenomy commented Dec 7, 2023

Closing to open a new PR directly on this repo to be able to run validate-interface

@mdenomy mdenomy closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants