use 'lax' instead of 'Lax' as default for cookie sameSite option when secure is set to 'auto' #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to support @fastify/cookie ^11.0.0 The downstream jshttp/cookie module now enforces the sameSite option to be lowercase, which means this default is causing the plugin to throw when setting the session cookie. Signed-off-by: Niall Molloy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to support @fastify/cookie ^11.0.0
When setting the secure option to 'auto' the cookie option of 'Lax' is being set by default for non HTTPS traffic, which is causing the jshttp/cookie module to throw as it now only supports the lowercase option of 'lax'.
Had to update the tests to check for maxAge 0 on expiry which @fastify/cookie is now also having to set due to changes in jshttp/cookie.