Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the ability to configure cookie options within a route #260

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Added the ability to configure cookie options within a route #260

merged 4 commits into from
Jul 25, 2024

Conversation

ogheo
Copy link
Contributor

@ogheo ogheo commented Jul 4, 2024

This PR add the ability to configure cookie options within a route. Relates to #257

Checklist

mcollina
mcollina approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from gurgunday July 8, 2024 16:42
gurgunday
gurgunday reviewed Jul 8, 2024
View reviewed changes
lib/session.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gurgunday
gurgunday requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#260 (comment) needs resolution

@ogheo @gurgunday
Fixed usage of regenerate, preserve old cookieOpts
9c16563 
Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Signed-off-by: Oleg Gheorghita <[email protected]>
gurgunday
gurgunday reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

One last thing, can you also add this test that tests the feature with regenerate?

Thanks

@ogheo
Copy link
Contributor Author

ogheo commented Jul 10, 2024

@gurgunday, I updated Override global options test with regenerate changes, is that ok or would you like to add it as a separate test?

gurgunday
gurgunday approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ogheo
Copy link
Contributor Author

ogheo commented Jul 25, 2024

@mcollina @gurgunday can we merge or something else is required?

@mcollina mcollina merged commit 2a0ffbe into fastify:master Jul 25, 2024
14 checks passed
@ogheo ogheo deleted the session-cookie-opts branch July 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogheo @mcollina @gurgunday