Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export cookie types #221

Merged
merged 3 commits into from
Nov 21, 2023
Merged

export cookie types #221

merged 3 commits into from
Nov 21, 2023

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Nov 20, 2023

Not sure if there's a way to this without creating an extra interface

Closes #213

@gurgunday gurgunday requested a review from a team November 20, 2023 15:00
types/types.d.ts Outdated Show resolved Hide resolved
@gurgunday gurgunday requested a review from mcollina November 20, 2023 19:49
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday
Copy link
Member Author

I initially thought encode wasn’t part of the cookie options so it’s omitted here, I have to change that before merging

@gurgunday gurgunday merged commit fad6a8f into fastify:master Nov 21, 2023
19 checks passed
bodinsamuel referenced this pull request in specfy/specfy Nov 30, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/session](https://togithub.com/fastify/session) | [`10.5.0`
->
`10.6.1`](https://renovatebot.com/diffs/npm/@fastify%2fsession/10.5.0/10.6.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fsession/10.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fsession/10.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fsession/10.5.0/10.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fsession/10.5.0/10.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/session (@&#8203;fastify/session)</summary>

###
[`v10.6.1`](https://togithub.com/fastify/session/releases/tag/v10.6.1)

[Compare
Source](https://togithub.com/fastify/session/compare/v10.6.0...v10.6.1)

#### What's Changed

- export the correct cookie options interface by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[https://github.com/fastify/session/pull/223](https://togithub.com/fastify/session/pull/223)

**Full Changelog**:
fastify/session@v10.6.0...v10.6.1

###
[`v10.6.0`](https://togithub.com/fastify/session/releases/tag/v10.6.0)

[Compare
Source](https://togithub.com/fastify/session/compare/v10.5.0...v10.6.0)

#### What's Changed

- perf: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/session/pull/210](https://togithub.com/fastify/session/pull/210)
- chore: add `.gitattributes` file by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/session/pull/212](https://togithub.com/fastify/session/pull/212)
- perf(lib/fastifysession): optimize split param by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/session/pull/214](https://togithub.com/fastify/session/pull/214)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/session/pull/217](https://togithub.com/fastify/session/pull/217)
- Added documentation for import of modules w/ declaration merging by
[@&#8203;VIEWVIEWVIEW](https://togithub.com/VIEWVIEWVIEW) in
[https://github.com/fastify/session/pull/220](https://togithub.com/fastify/session/pull/220)
- Updated import as per redis-connect docs by
[@&#8203;maxt41](https://togithub.com/maxt41) in
[https://github.com/fastify/session/pull/219](https://togithub.com/fastify/session/pull/219)
- export cookie types by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[https://github.com/fastify/session/pull/221](https://togithub.com/fastify/session/pull/221)

#### New Contributors

- [@&#8203;VIEWVIEWVIEW](https://togithub.com/VIEWVIEWVIEW) made their
first contribution in
[https://github.com/fastify/session/pull/220](https://togithub.com/fastify/session/pull/220)
- [@&#8203;maxt41](https://togithub.com/maxt41) made their first
contribution in
[https://github.com/fastify/session/pull/219](https://togithub.com/fastify/session/pull/219)
- [@&#8203;gurgunday](https://togithub.com/gurgunday) made their first
contribution in
[https://github.com/fastify/session/pull/221](https://togithub.com/fastify/session/pull/221)

**Full Changelog**:
fastify/session@v10.5.0...v10.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google phasing out third-party cookies
2 participants