Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7 partially #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

arttumiettinen
Copy link

A quick and dirty fix for cgalmesh part of issue #7 (missing regions in cgalmesh output). Support for non-uint8 images and >256 regions is also included. This is probably just a starting point for complete fix but maybe it helps anyway.

Arttu Miettinen added 3 commits January 3, 2020 10:44
…on in cgalmesh with the custom initialization by Laurent Irineau.
…on in cgalmesh with the custom initialization by Laurent Irineau.
@fangq
Copy link
Owner

fangq commented Feb 10, 2020

thanks @lrineau, sorry for taking this long, had been overwhelmed by department services at the beginning of the semester, and finally have time to start working on iso2mesh.

I just tried to compile your updated source codes on my Ubuntu 16.04 machine (with cgal 4.7) , but it failed with the following error message

[ 25%] Building CXX object CMakeFiles/mesh_3D_image.dir/mesh_3D_image.cpp.o
In file included from /home/users/fangq/space/Libraries/iso2mesh/tools/cgalmesh/mesh_3D_image.cpp:15:0:
/home/users/fangq/space/Libraries/iso2mesh/tools/cgalmesh/initialise_triangulation_from_labeled_image.h:14:33: fatal error: CGAL/license/Mesh_3.h: No such file or directory

is this path specific for cgal 5? can the code accommodate other cgal releases by placing #ifdef macros? thanks

@lrineau
Copy link
Contributor

lrineau commented Feb 11, 2020

The file <CGAL/license/Mesh_3.h> has been added in CGAL-4.10. Maybe you can try again with that #include line remove. But the file Mesh_3/include/CGAL/Mesh_3/initialize_triangulation_from_labeled_image.h was added in CGAL-4.9. It might not be compatible with CGAL-4.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants