Commits on Nov 12, 2018

1. Fix incorrect sizes calculations causing loading overhead image from … …

   …srcset
   
   If display has less width than height (like on mobile) then Math.round(slide.width / slide.height * 100)) can produce incorrect view port value for sizes attribute. 
   
   For example :
   Device has width 689 and height 744. Image has 700 width and 506 height. 
   So according to the code condition  : 
   700/506 > 1 = true
   689/744 > 1 = false
   then :
   700/506*100 = 0.0138
   
   So this generate sizes="138vw" which will be incorrect and a browser load a correct image from a srcset and also load another candidate from srcset which appropriate specified. But browser doesn't set this second candidate and everything looks normal except the thing that browser load this second image and therefore using additional traffic.
   You can check this in Dev Tools > Network

   

   noth8 authored Nov 12, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 9d8e5bb
   • Browse repository at this point

   Copy the full SHA

   9d8e5bb View commit details

   Browse the repository at this point in the history