This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Fixed #2122 - Focusable HTML5 video - Fixed #2128 - Missing smallBtn on mobile - Fixed #2096 - autoStart fullscreen AND slideshow - Fixed #2097 - German translation - Fixed #2132 - Youtube fullscreen - Captions now have linear-gradient background (instead of background image for pseudo element) and can have max-height and vertical scrollbar - Improved design for phones having the notch (https://webkit.org/blog/7929/designing-websites-for-iphone-x/)
- Loading branch information
Showing
10 changed files
with
112 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3.5.3 :)
Thank you for the update! I am still looking for v3.6 (or whatever version) with these thow addtions:
Keep good work!
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
But I think the text on page https://github.com/fancyapps/fancybox should be changed into "updated to version 3,5.3"
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acwolff Yes, I noticed that but, unfortunately, it is a big pain to change something in git without breaking something up (see https://help.github.com/articles/changing-a-commit-message/), so, that typo will stay to remind to be more careful in the future :)
@Eldenroot Sorry, I have been working on v4 for some time and will resume the work; current branch will receive small patches only.
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fancyapps - no need to say sorry my friend, I am looking forward to see v4 sooner or later :)
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please give more details about the new “mproved design for phones having the notch” , because I see no differente with the previous version.
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acwolff Did you check the link in the description - https://webkit.org/blog/7929/designing-websites-for-iphone-x/ ? I think it should be pretty clear after reading that.
Basically, CSS now contains these new CSS environment variables (like safe-area-inset-left, etc) and functions (env() and max()). Note that in order for your page to look good on phones like iPhone X/XS, you also need to add:
<meta name='viewport' content='initial-scale=1, viewport-fit=cover'>
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, in my case this is not correctly working on a iPhoneXR, see this test, On an iPhone XR I see with version 3.5.3:
and with an iPhone5:
But with version 3,5.2 I see on an iPhone XR:
To solve this problem, I have to remove from the css file:
/* Using calc to trick sass */
@supports (padding: 0px) {
.fancybox-caption {
padding: 50px calc(max(12px, env(safe-area-inset-right))) calc(max(12px, env(safe-area-inset-bottom))) calc(max(25px, env(safe-area-inset-left))); } }
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the correct
viewport
meta tag.5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I have this:
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is what I see (from your link):
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my fault, but it gets even worse after I corrected it: I can't removed the iPhone address bar and the caption is no longer visible:
I used before the side panel to remove the iPhone addres bar.
To see thge caption I have to rotate the iPhone:
Edit:
I had hidden the scroll bars, if I disable that it becomes better:
But the bacground area of the caption is incorrect and it is difficult to reproduce this view, most times i get the address bar in view.
To get the background correct, I have to remove the /* Using calc to trick sass */ code.
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that is how iOS works and has been "working" for years. Other than that - it works fine.
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I had no problems at all with version 3.5.2, so I will make this viewport-fit=cover an option or disable it.
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works correctly for my jAlbum FancyBox skin if I change your sass code into:
as you can see here. This displays on an iPhone XR as:
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, your CSS values are not valid. But I just noticed one thing - Gulp broke the code by changing this line -
@supports (padding: max(0px)) {
(https://github.com/fancyapps/fancybox/blob/master/src/css/core.css#L643)
into
@supports (padding: 0px) {
(https://github.com/fancyapps/fancybox/blob/master/dist/jquery.fancybox.css#L584)
And this is very important change. I'll try to figure out how to overcome this.
5f7dd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it might be invalid, but it did work correctly.
But I changed the code into:
Is this correct?
It works OK as you can see here.
Edit:
I added this:
.fancybox-caption {
padding: 12px;
}
to prevent that the caption is partly hidden by the horizontal line generated by iOS: