chore: (BREADING CHANGE) spec v1.13 autogen #1981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
td-famedly
force-pushed
the
td/specv1.13
branch
from
b19c58f to
2d2f6af
Compare
td-famedly
changed the title
| @@ -4648,7 +4693,7 @@ class Api { | |||
| if (response.statusCode != 200) unexpectedResponse(response, responseBody); | |||
| final responseString = utf8.decode(responseBody); | |||
| final json = jsonDecode(responseString); | |||
| return ignore(json); | |||
| return json as Map<String, Object?>; | |||
There was a problem hiding this comment.
this is weird, I can't find that in the spec text.
There was a problem hiding this comment.
The spec now returns an event_id like this:
{
"event_id": "$YUwRidLecu:example.com"
}so returning json is at least not wrong but fetching the string, like we do with the sendMessage method would be better
nico-famedly
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.