postLoad before setting famedly calls #1832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
td-famedly
changed the title
krille-chan
requested changes
May 28, 2024
There was a problem hiding this comment.
hmm, no that shouldn't be the cause. If you are in a room, you have already post loaded it. If you set powerlevels as important state event, you do not need to postload it.
I would not set powerlevel as important state event as this then would load it for all rooms which is bad for the performance on app start.
td-famedly
changed the title
|
hm makes sense, needs more work then. for context also related to #1772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1830
Found a missing postLoad from a maybe code path, this does not fix the admin indicator missing bug, you probably want to set powerlevels as a required event for that