Fix potential wrong-over-optimization in math utilities

Signed-off-by: falkTX <[email protected]>
falkTX · Jan 2, 2024 · 73ddea2 · 73ddea2
1 parent 46792aa
commit 73ddea2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/source/utils/CarlaMathUtils.hpp b/source/utils/CarlaMathUtils.hpp
@@ -179,7 +179,7 @@ void carla_addFloats(float dest[], const float src[], const std::size_t count) n
         if (!std::isfinite(src[i]))
             __builtin_unreachable();
        #endif
-        *dest++ += *src++;
+        dest[i] += src[i];
     }
 }
 
@@ -217,7 +217,7 @@ void carla_fillFloatsWithSingleValue(float data[], const float& value, const std
             if (!std::isfinite(data[i]))
                 __builtin_unreachable();
            #endif
-            *data++ = value;
+            data[i] = value;
         }
     }
 }
@@ -302,7 +302,7 @@ void carla_multiply(float data[], const float& multiplier, const std::size_t cou
             if (!std::isfinite(data[i]))
                 __builtin_unreachable();
            #endif
-            *data++ *= multiplier;
+            data[i] *= multiplier;
         }
     }
 }

diff --git a/source/utils/CarlaUtils.hpp b/source/utils/CarlaUtils.hpp
@@ -406,7 +406,7 @@ void carla_add(T dest[], const T src[], const std::size_t count) noexcept
     CARLA_SAFE_ASSERT_RETURN(count > 0,);
 
     for (std::size_t i=0; i<count; ++i)
-        *dest++ += *src++;
+        dest[i] += src[i];
 }
 
 /*
@@ -422,7 +422,7 @@ void carla_addWithMultiply(T dest[], const T src[], const T& multiplier, const s
     CARLA_SAFE_ASSERT_RETURN(count > 0,);
 
     for (std::size_t i=0; i<count; ++i)
-        *dest++ += *src++ * multiplier;
+        dest[i] += src[i] * multiplier;
 }
 
 /*
@@ -453,7 +453,7 @@ void carla_copyWithMultiply(T dest[], const T src[], const T& multiplier, const
     CARLA_SAFE_ASSERT_RETURN(count > 0,);
 
     for (std::size_t i=0; i<count; ++i)
-        *dest++ = *src++ * multiplier;
+        dest[i] = src[i] * multiplier;
 }
 
 /*
@@ -473,7 +473,7 @@ void carla_fill(T data[], const T& value, const std::size_t count) noexcept
     else
     {
         for (std::size_t i=0; i<count; ++i)
-            *data++ = value;
+            data[i] = value;
     }
 }
 
@@ -494,7 +494,7 @@ void carla_multiply(T data[], const T& multiplier, const std::size_t count) noex
     else
     {
         for (std::size_t i=0; i<count; ++i)
-            *data++ *= multiplier;
+            data[i] *= multiplier;
     }
 }