-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable peribolos-syncer job for all repos #1344
Conversation
run_if_changed: 'OWNERS$' | ||
spec: | ||
containers: | ||
- image: gcr.io/maxgio92/peribolos-syncer:0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before using the falcosecurity
package, we need falcosecurity/peribolos-syncer#11 in order to release the v0.2.0 to its repository.
@FedeDP ready for review |
- --peribolos-config-repository=test-infra | ||
- --peribolos-config-git-ref=master | ||
- --owners-repository=libs | ||
- --owners-git-ref=main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be master
for eg: driverkit, libs, falco... repositories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, good catch! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FedeDP it should be aligned now.
Plus, I've removed configurations for the libsinsp and the libscap repos.
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Charts is still using a wrong ref for default branch; moreover, event-generator
is missing, right?
Looking at https://github.com/falcosecurity/test-infra/blob/master/config/config.yaml, we miss:
Some of them might be archived thus there is no need to add them (i guess?), even if, since they are listed in config yaml, i'd definitely add them here too. |
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Hey @FedeDP, thanks and sorry for the big delay. I've added the conf for the mentioned repos, except for the archive repositories:
WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks, now this LGTM!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Feel free to unhold whenever you wish ;) |
/unhold |
@maxgio92: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #1343