Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable peribolos-syncer job for all repos #1344

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Enable peribolos-syncer job for all repos #1344

merged 3 commits into from
Feb 24, 2024

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented Jan 4, 2024

Fixes #1343

@maxgio92 maxgio92 changed the title WIP: chore(config/jobs): add peribolos-syncer to main repos WIP: Enable peribolos-syncer job for all repos Jan 4, 2024
@poiana poiana requested review from FedeDP and jonahjon January 4, 2024 16:24
@poiana poiana added the approved label Jan 4, 2024
run_if_changed: 'OWNERS$'
spec:
containers:
- image: gcr.io/maxgio92/peribolos-syncer:0.2.0
Copy link
Member Author

@maxgio92 maxgio92 Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before using the falcosecurity package, we need falcosecurity/peribolos-syncer#11 in order to release the v0.2.0 to its repository.

@maxgio92 maxgio92 changed the title WIP: Enable peribolos-syncer job for all repos Enable peribolos-syncer job for all repos Jan 5, 2024
@maxgio92
Copy link
Member Author

maxgio92 commented Jan 5, 2024

@FedeDP ready for review

- --peribolos-config-repository=test-infra
- --peribolos-config-git-ref=master
- --owners-repository=libs
- --owners-git-ref=main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be master for eg: driverkit, libs, falco... repositories?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, good catch! Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedeDP it should be aligned now.

Plus, I've removed configurations for the libsinsp and the libscap repos.

@FedeDP
Copy link
Contributor

FedeDP commented Jan 8, 2024

/hold

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charts is still using a wrong ref for default branch; moreover, event-generator is missing, right?

@FedeDP
Copy link
Contributor

FedeDP commented Jan 9, 2024

Looking at https://github.com/falcosecurity/test-infra/blob/master/config/config.yaml, we miss:

  • event-generator
  • dbg-go
  • cncf-green-review-testing
  • client-py
  • client-rs
  • falco-aws-terraform
  • falco-exporter
  • falco-playground
  • flycheck-falco-rules
  • k8s-metacollector
  • kilt
  • libs-sdk-go
  • pdig
  • plugin-sdk-go
  • plugin-sdk-cpp
  • syscalls-bumper

Some of them might be archived thus there is no need to add them (i guess?), even if, since they are listed in config yaml, i'd definitely add them here too.

@maxgio92
Copy link
Member Author

Hey @FedeDP, thanks and sorry for the big delay. I've added the conf for the mentioned repos, except for the archive repositories:

  • client-py
  • client-rs
  • kilt
  • pdig

WDYT?

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks, now this LGTM!

@poiana
Copy link
Contributor

poiana commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Feb 23, 2024

Feel free to unhold whenever you wish ;)

@maxgio92
Copy link
Member Author

/unhold

@poiana poiana merged commit 426d787 into master Feb 24, 2024
4 of 5 checks passed
@poiana poiana deleted the issue/1343 branch February 24, 2024 17:44
@poiana
Copy link
Contributor

poiana commented Feb 24, 2024

@maxgio92: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key peribolos-syncer-charts.yaml using file config/jobs/update-github-teams/peribolos-syncer-charts.yaml
  • key peribolos-syncer-client-go.yaml using file config/jobs/update-github-teams/peribolos-syncer-client-go.yaml
  • key peribolos-syncer-cncf-green-review-testing.yaml using file config/jobs/update-github-teams/peribolos-syncer-cncf-green-review-testing.yaml
  • key peribolos-syncer-community.yaml using file config/jobs/update-github-teams/peribolos-syncer-community.yaml
  • key peribolos-syncer-contrib.yaml using file config/jobs/update-github-teams/peribolos-syncer-contrib.yaml
  • key peribolos-syncer-dbg-go.yaml using file config/jobs/update-github-teams/peribolos-syncer-dbg-go.yaml
  • key peribolos-syncer-deploy-kubernetes.yaml using file config/jobs/update-github-teams/peribolos-syncer-deploy-kubernetes.yaml
  • key peribolos-syncer-driverkit.yaml using file config/jobs/update-github-teams/peribolos-syncer-driverkit.yaml
  • key peribolos-syncer-event-generator.yaml using file config/jobs/update-github-teams/peribolos-syncer-event-generator.yaml
  • key peribolos-syncer-evolution.yaml using file config/jobs/update-github-teams/peribolos-syncer-evolution.yaml
  • key peribolos-syncer-falco-aws-terraform.yaml using file config/jobs/update-github-teams/peribolos-syncer-falco-aws-terraform.yaml
  • key peribolos-syncer-falco-exporter.yaml using file config/jobs/update-github-teams/peribolos-syncer-falco-exporter.yaml
  • key peribolos-syncer-falco-playground.yaml using file config/jobs/update-github-teams/peribolos-syncer-falco-playground.yaml
  • key peribolos-syncer-falco-website.yaml using file config/jobs/update-github-teams/peribolos-syncer-falco-website.yaml
  • key peribolos-syncer-falco.yaml using file config/jobs/update-github-teams/peribolos-syncer-falco.yaml
  • key peribolos-syncer-falcoctl.yaml using file config/jobs/update-github-teams/peribolos-syncer-falcoctl.yaml
  • key peribolos-syncer-falcosidekick-ui.yaml using file config/jobs/update-github-teams/peribolos-syncer-falcosidekick-ui.yaml
  • key peribolos-syncer-falcosidekick.yaml using file config/jobs/update-github-teams/peribolos-syncer-falcosidekick.yaml
  • key peribolos-syncer-flycheck-falco-rules.yaml using file config/jobs/update-github-teams/peribolos-syncer-flycheck-falco-rules.yaml
  • key peribolos-syncer-k8s-metacollector.yaml using file config/jobs/update-github-teams/peribolos-syncer-k8s-metacollector.yaml
  • key peribolos-syncer-kernel-crawler.yaml using file config/jobs/update-github-teams/peribolos-syncer-kernel-crawler.yaml
  • key peribolos-syncer-kernel-testing.yaml using file config/jobs/update-github-teams/peribolos-syncer-kernel-testing.yaml
  • key peribolos-syncer-libs-sdk-go.yaml using file config/jobs/update-github-teams/peribolos-syncer-libs-sdk-go.yaml
  • key peribolos-syncer-libs.yaml using file config/jobs/update-github-teams/peribolos-syncer-libs.yaml
  • key peribolos-syncer-peribolos-syncer.yaml using file config/jobs/update-github-teams/peribolos-syncer-peribolos-syncer.yaml
  • key peribolos-syncer-pigeon.yaml using file config/jobs/update-github-teams/peribolos-syncer-pigeon.yaml
  • key peribolos-syncer-plugin-sdk-cpp.yaml using file config/jobs/update-github-teams/peribolos-syncer-plugin-sdk-cpp.yaml
  • key peribolos-syncer-plugin-sdk-go.yaml using file config/jobs/update-github-teams/peribolos-syncer-plugin-sdk-go.yaml
  • key peribolos-syncer-plugins.yaml using file config/jobs/update-github-teams/peribolos-syncer-plugins.yaml
  • key peribolos-syncer-rules.yaml using file config/jobs/update-github-teams/peribolos-syncer-rules.yaml
  • key peribolos-syncer-syscalls-bumper.yaml using file config/jobs/update-github-teams/peribolos-syncer-syscalls-bumper.yaml
  • key peribolos-syncer-test-infra.yaml using file config/jobs/update-github-teams/peribolos-syncer-test-infra.yaml
  • key peribolos-syncer-testing.yaml using file config/jobs/update-github-teams/peribolos-syncer-testing.yaml
  • key peribolos-syncer.yaml using file ``

In response to this:

Fixes #1343

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run peribolos-syncer jobs on all repositories
3 participants