feat(build/registry): return built oci artifact digest #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
do-not-merge/work-in-progress
kind/feature
|
/cc @LucaGuerra |
|
With the occasion, would we like to improve code coverage? |
maxgio92
changed the title
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
|
Hi @falcosecurity/rules-maintainers, PR ready to be reviewed :-) |
incertum
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
/approve
@LucaGuerra if you have additional feedback or suggestions, we can open a follow up PR, thanks.
incertum
approved these changes
Aug 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incertum, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area registry
/area build
What this PR does / why we need it:
This PR introduces the return of the built OCI artifact's digest.
The digest can later be used to securely reference it.
Which issue(s) this PR fixes:
Fixes #63
Special notes for your reviewer:
This is part of the work for securing the Falco supply chain. In detail of signatures of Falco OCI artifacts, you can read here.
Moreover, this is a very simple implementation. A stage of improvements is open for later.