Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(decl/runners): add host runner and test serialization support #236

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Oct 30, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
This PR adds the definition runner and runner builder, and provides implementations for them. Specifically, it introduces the host runner, which can be used to run a test on the host system. The host runner supports the generation of the process chain, as specified by the user in the test description. In order to enable communication of the test configuration from a parent process to a child process (spawned during the creation of the process chain), this PR adds support for test serialization.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Leonardo Di Giovanna <[email protected]>
Co-authored-by: Aldo Lacuku <[email protected]>
@poiana poiana requested review from alacuku and leogr October 30, 2024 09:18
@ekoops ekoops changed the title feat(decl/runners): add host runner and test serialization support wip: feat(decl/runners): add host runner and test serialization support Oct 30, 2024
ekoops and others added 5 commits October 30, 2024 11:06
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Co-authored-by: Aldo Lacuku <[email protected]>
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Co-authored-by: Aldo Lacuku <[email protected]>
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Co-authored-by: Aldo Lacuku <[email protected]>
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Co-authored-by: Aldo Lacuku <[email protected]>
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Co-authored-by: Aldo Lacuku <[email protected]>
@ekoops ekoops changed the title wip: feat(decl/runners): add host runner and test serialization support feat(decl/runners): add host runner and test serialization support Oct 30, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Oct 30, 2024

LGTM label has been added.

Git tree hash: 0746d96fb31746e2cbc6f280efe0985b5e188ad3

@poiana
Copy link

poiana commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d1fd1f6 into falcosecurity:declarative-testing Oct 30, 2024
4 of 6 checks passed
@ekoops ekoops deleted the ekoops/runner branch October 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants