Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pkg/generate): properly sort kernelurls before dumping them. #37

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Oct 24, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

This way, we always get same sorting for headers.
It should help reduce the diff between daily test-infra dbg updates: falcosecurity/test-infra#1273

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

This way, we always get same sorting for headers.

Signed-off-by: Federico Di Pierro <[email protected]>
@poiana
Copy link

poiana commented Oct 24, 2023

@FedeDP: The label(s) kind/cleanup, area/pkg cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

This way, we always get same sorting for headers.
It should help reduce the diff between daily test-infra dbg updates: falcosecurity/test-infra#1273

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented Oct 24, 2023

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/XS label Oct 24, 2023
maxgio92
maxgio92 previously approved these changes Oct 24, 2023
Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice catch @FedeDP!

Signed-off-by: Federico Di Pierro <[email protected]>
Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit dc2b3ad into main Oct 24, 2023
3 checks passed
@poiana poiana deleted the chore/sort_headers branch October 24, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants