Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove pinning of importlib-resources for Mailman tests #2169

Closed
wants to merge 1 commit into from
Closed

chore: remove pinning of importlib-resources for Mailman tests #2169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/tests-mailman.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
push:
branches:
- master
pull_request:
branches:
- master

jobs:
run_tox:
Expand Down
3 changes: 0 additions & 3 deletions tools/testing/fetch_mailman.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,11 @@ cd $MAILMAN_PATH
# git checkout tags/$MAILMAN_VERSION

# NOTE(vytas): Patch tox.ini to introduce a new Falcon environment.
# TODO(vytas): Remove the shim pinning importlib-resources once
# https://gitlab.com/mailman/mailman/-/merge_requests/1130 is merged upstream.
cat <<EOT >> tox.ini

[testenv:falcon-nocov]
basepython = python3.8
commands_pre =
pip install "importlib-resources < 6.0"
pip uninstall -y falcon
pip install $FALCON_ROOT
EOT
Expand Down
Loading