Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'wall or move' rule (for Atlantis) #728

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

RainRat
Copy link
Contributor

@RainRat RainRat commented Sep 25, 2023

No description provided.

src/movegen.cpp Outdated Show resolved Hide resolved
@ianfab
Copy link
Member

ianfab commented Dec 23, 2023

Let me know if there is anything I can help with regarding this PR. I have no problem with keeping this open if you plan to return to it at a later point, just want to briefly clarify what is the status.

@RainRat
Copy link
Contributor Author

RainRat commented Jan 4, 2024

In case you haven't seen the new commit, I believe I have fixed the problem.

@ianfab
Copy link
Member

ianfab commented Feb 10, 2024

Sorry for the long delay. When I run a search on the starting position for atlantis with debug=yes then it raises a failed assertion at depth 1:

stockfish: position.cpp:1032: bool Stockfish::Position::legal(Stockfish::Move) const: Assertion `is_ok(m)' failed.

Could you please have a look?

@RainRat
Copy link
Contributor Author

RainRat commented Feb 13, 2024

I wasn't able to reproduce this error.

  • I merged the latest changes in an odd way, but it should still be understandable.

@ianfab
Copy link
Member

ianfab commented Feb 13, 2024

Here are the exact commands I used to reproduce the error:

make clean
make -j2 ARCH=x86-64-bmi2 build debug=yes
./stockfish load variants.ini
setoption name UCI_Variant value atlantis
position startpos
go

@RainRat
Copy link
Contributor Author

RainRat commented Feb 14, 2024

ok, i think this might be the fix.

@ianfab ianfab merged commit bbe0d95 into fairy-stockfish:master Mar 1, 2024
16 checks passed
@ianfab
Copy link
Member

ianfab commented Mar 1, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants