-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos fix by misspell-fixer (Sourcery refactored) #17
base: create-pull-request/patch
Are you sure you want to change the base?
Typos fix by misspell-fixer (Sourcery refactored) #17
Conversation
payload = start_osparc_job("python", input_file_paths) | ||
|
||
return payload | ||
return start_osparc_job("python", input_file_paths) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function start_python_osparc_job
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
payload = start_osparc_job("matlab", input_file_paths) | ||
|
||
return payload | ||
return start_osparc_job("matlab", input_file_paths) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function start_matlab_osparc_job
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
print(f"Now downloading to disk path:") | ||
print("Now downloading to disk path:") | ||
results_file: File = outputs.results[output_result_to_use] | ||
#print(f"file id: {results_file.id}") | ||
download_path: str = files_api.download_file(file_id=results_file.id) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function check_job_status
refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring
)
dir_path_for_job_outputs = os.path.join(static_dir, "jobs-results", job_id) | ||
|
||
return dir_path_for_job_outputs | ||
return os.path.join(static_dir, "jobs-results", job_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_static_dir_for_job
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.53%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #1 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
create-pull-request/patch
branch, then run:Help us improve this pull request!