Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #45 add Darwin support #51

Merged
merged 1 commit into from
Nov 25, 2024
Merged

resolves #45 add Darwin support #51

merged 1 commit into from
Nov 25, 2024

Conversation

slonopotamus
Copy link
Contributor

No description provided.

@slonopotamus slonopotamus changed the title resolves #45 add support for Darwin resolves #45 add Darwin support Nov 16, 2024
fahedouch
fahedouch reviewed Nov 16, 2024
View reviewed changes
logrotate_unix.go Outdated Show resolved Hide resolved
fahedouch
fahedouch reviewed Nov 16, 2024
View reviewed changes
logrotate_freebsd.go Outdated Show resolved Hide resolved
@fahedouch fahedouch added this to the v0.2.2 milestone Nov 17, 2024
@slonopotamus slonopotamus force-pushed the darwin branch 3 times, most recently from c821978 to 95a2dfd Compare November 17, 2024 12:20
fahedouch
fahedouch reviewed Nov 17, 2024
View reviewed changes
logrotate_unix.go Outdated Show resolved Hide resolved
@slonopotamus slonopotamus marked this pull request as draft November 17, 2024 14:45
@slonopotamus
Copy link
Contributor Author

Converting to draft. I'd prefer #52 to be merged first, that will allow testing whether FreeBSD actually needs a separate codepath or we can use the same Unix code for all non-Windows platforms.

@slonopotamus slonopotamus force-pushed the darwin branch 4 times, most recently from 3274f42 to 1ab0893 Compare November 25, 2024 11:39
@slonopotamus slonopotamus marked this pull request as ready for review November 25, 2024 11:41
@slonopotamus
Copy link
Contributor Author

Ready for review.

I had to bump Golang to 1.21 on CI to make //go:build unix work (1.21 was chosen because this is what go.mod currently declares). I also had to bump golangci-lint to v1.51.2 so it would properly work with Golang 1.21.

@fahedouch
Copy link
Owner

LGTM, I left small comment :)

fahedouch
fahedouch approved these changes Nov 25, 2024
View reviewed changes
Copy link
Owner

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch merged commit 0240e7a into fahedouch:main Nov 25, 2024
7 checks passed
@slonopotamus slonopotamus deleted the darwin branch November 25, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahedouch fahedouch fahedouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@slonopotamus @fahedouch