add openExistingOrNew unit test

Signed-off-by: Arjun Raja Yogidas <[email protected]>

logrotate.go

@@ -269,9 +269,8 @@ func (l *Logger) backupName(name, nameTimeFormat string, local bool) (string, er
 	return filepath.Join(dir, filename), nil
 }
 
-// openExistingOrNew opens the logfile if it exists and if the current write
-// would not put it over MaxBytes.  If there is no such file or the write would
-// put it over the MaxBytes, a new file is created.
+// openExistingOrNew opens the logfile if it exists.
+// If there is no such file a new file is created.
 func (l *Logger) openExistingOrNew() error {
 	l.millRun()
 

logrotate_test.go

@@ -78,6 +78,44 @@ func TestOpenExisting(t *testing.T) {
 	fileCount(dir, 1, t)
 }
 
+func TestOpenExistingOrNew(t *testing.T) {
+	dir := makeTempDir("TestOpenExistingOrNew", t)
+	defer os.RemoveAll(dir)
+
+	filename := logFile(dir)
+	l := &Logger{
+		Filename: filename,
+		MaxBytes: 100,
+	}
+
+	// File doesn't exist
+	err := l.openExistingOrNew()
+	isNil(err, t)
+	assert(l.file != nil, t, "Expected file to be opened")
+	equals(int64(0), l.size, t)
+
+	content := []byte("Hello, World!")
+	_, err = l.file.Write(content)
+	isNil(err, t)
+	l.size = int64(len(content))
+
+	// Close
+	err = l.file.Close()
+	isNil(err, t)
+	l.file = nil
+
+	// File exists and is not over MaxBytes
+	err = l.openExistingOrNew()
+	isNil(err, t)
+	assert(l.file != nil, t, "Expected file to be opened")
+	equals(int64(len(content)), l.size, t)
+
+	// Close
+	err = l.file.Close()
+	isNil(err, t)
+	l.file = nil
+}
+
 func TestWriteTooLong(t *testing.T) {
 	currentTime = fakeTime
 	dir := makeTempDir("TestWriteTooLong", t)