Check validity of regexes before sending them to the frontend + tooltip for invalid regex #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdpoora
force-pushed
the
bug/regex_validity
branch
2 times, most recently
from
eb2f005 to
014923d
Compare
vereecw
requested changes
Nov 26, 2024
|
still does the request sometimes even though the regex is invalid? When you enter an invalid regex for assets/measurement in the regular query editor en manually press the refresh button |
vdpoora
force-pushed
the
bug/regex_validity
branch
2 times, most recently
from
9b13756 to
11bdb06
Compare
Don't think I can easily prevent that, might be a bigger refactor than it is worth |
vdpoora
force-pushed
the
bug/regex_validity
branch
2 times, most recently
from
cf4ad69 to
67b5388
Compare
vereecw
reviewed
Nov 28, 2024
vdpoora
force-pushed
the
bug/regex_validity
branch
from
67b5388 to
b2ee8f2
Compare
vereecw
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/factry/Historian/_workitems/edit/24117