Creation of Server Settings Based On Environment Variables

[deefdragon]

Using the server settings files generated from a clean start of the container, This commit adds 3 template json files, and one script file to resolve #299

This script file uses 4 functions to validate different parameter inputs (string, boolean, number, or empty) and makes sure that the input from the environment variable matches the required format. It also makes sure that there is a value to replace it with. If either of these cases is false, the default value is used.

Each file is created from the template in it's own function to allow for addition of or changing of keys in the future.

The current script is complete for the basic server settings, but not for the map settings or map-gen settings. The template keys have not yet been inserted into the template json file.

This is a request for review, to confirm that the required standards of error-proof and maintainable are met, and to discuss possible improvements.

[SuperSandro2000]

Pipeline will be green if you don't merge master into master.

[deefdragon]

On the master to master, would it be best if I closed this and opened a new one? and would I merge a different branch on my end, or into a different branch on the factoriotools end?

[SuperSandro2000]

On the master to master, would it be best if I closed this and opened a new one?

Don't know right now if you can change it. If yes change it if no just leave it like it is.

and would I merge a different branch on my end, or into a different branch on the factoriotools end?

You would merge a different branch on your end into factoriotools master.
Take a look at #267

[SuperSandro2000]

Looking great!

[deefdragon]

So, unless you see anything that needs to be changed, I will make the necessary changes to the docker-entrypoint.

[SuperSandro2000]

BTW How do you plan to update the templates in the future?

[deefdragon]

By hand comparison. there shouldn't be too many, if ANY changes between minor versions at this point and few between major versions, unless they do a full settings refactor or something.

[deefdragon]

Right then, documentation created/updated, and control variables added.

The new method will not run unless GENERATE_SETTINGS_FILES is true, otherwise, the old method(copy from /opt/factorio/data) is used.

The value of FORCE_GENERATE_SETTINGS_FILES will determine if the settings are generated and replaced if the files exist already. Unless true, the generation will not run if the files exist already. This allows for the override of settings if needed by restarting the container.

Unless you see anything that needs to be added, changed, or removed, it should be good to merge.
I would like if someone else could sanity check me and also test it, but it should be good.

[SuperSandro2000]

I don't really have time to test this right now. Can someone else verify that this does not break anything and works like it should?

[deefdragon]

Im going to add a commit to add this to the 0.18 folder as well, and will try to test as in depth as I can this weekend.

I dont like being the only one to test it, but at this point, its been long enough that I dont think I will have the mental auto-correct that I would get after just writing it.

[deefdragon]

Closing for #304 . New branch name created accidentally. Running with it to allow for the checks to (hopefully) pass.