Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add type hint on Quote #396

Merged

Conversation

LeeDongGeon1996
Copy link
Member

@LeeDongGeon1996 LeeDongGeon1996 commented Aug 15, 2024

Description

  • Add type hint on Quote

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 changed the title feat: Add type hints feat: Add type hint on Quote Aug 15, 2024
@LeeDongGeon1996
Copy link
Member Author

LeeDongGeon1996 commented Aug 15, 2024

Need to rebase. please review the last two commits.

@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review August 15, 2024 16:01
@LeeDongGeon1996 LeeDongGeon1996 force-pushed the feat/add-type-hints-more branch from c07008f to c2573c7 Compare August 15, 2024 17:50
@LeeDongGeon1996 LeeDongGeon1996 enabled auto-merge (squash) August 15, 2024 17:52
@LeeDongGeon1996 LeeDongGeon1996 merged commit 5d788de into facioquo:main Aug 16, 2024
14 of 15 checks passed
@LeeDongGeon1996 LeeDongGeon1996 deleted the feat/add-type-hints-more branch August 16, 2024 16:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants