Prefix python modules #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a semi-automated change:
```bash
$ sed -i \
-e 's/^\(\s*\)\(state_dict = torch.hub\)/\1print(f"Going to download {url=} via torch.hub")\n\1\2/' \
utils.py
$ pname=dino
$ prefix-python-modules . --prefix $pname
```
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a semi-automated change and relies on the python-rope/rope refactoring library:
$ nix shell github:SomeoneSerge/pkgs#prefix-python-modules $ prefix-python-modules . --prefix dinoThis change extends generic names, like
utils, with the project project name.This way
dinocan be used in the same PYTHONPATH with other projects without the risk of collisionThe extra commit also adds a
pyproject.tomlfile, which is just an easy way to have wheels automatically generated. Wheels make it easier to packagedinoin distributions, including those other than pypi.The changes have been tested in a somewhat automated way12. Happy to revert or extend any particular bit if you like, just hoping to get the actual prefixes merged. Thanks
Footnotes
https://github.com/SomeoneSerge/pkgs/blob/0d2b35d8704636ffb6538c24b4e5c180d9bb17a3/python-packages/by-name/om/omnimotion/preprocess-dataset.nix#L14-L18 ↩
https://github.com/SomeoneSerge/pkgs/blob/0d2b35d8704636ffb6538c24b4e5c180d9bb17a3/python-packages/by-name/di/dino/package.nix#L29 ↩