Add new argument num_classes to eval scripts

[fabito]

No description provided.

[facebook-github-bot]

Hi @fabito!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[mathildecaron31]

Hi @fabito
I have just merged another PR dealing with the same issue in eval_linear.py. Can you update your PR accordingly :) ?
Thanks a lot for contributing

[fabito]

Done @mathildecaron31

[mathildecaron31]

Please rebase

[ketil-malde]

Good... but shouldn't this rather be automatically calculated from the number of directories in data_path/val and /train? What happens if I have more directories than num_labels? Or if val and train subdirectories don't match? (I can write the code for this, but would like to know if I misunderstand something here)

[woctezuma]

The pull request is just there to allow to specify the value of the function argument, which is otherwise used with its default value:

dino/eval_knn.py

Line 143 in cb71140

def knn_classifier(train_features, train_labels, test_features, test_labels, k, T, num_classes=1000):