Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit installation (PyTorch 2.0.0 -> 2.1.0) #372

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Edit installation (PyTorch 2.0.0 -> 2.1.0) #372

merged 1 commit into from
Dec 22, 2023

Conversation

J4BEZ
Copy link
Contributor

@J4BEZ J4BEZ commented Dec 15, 2023

requiremetns.txt[#352] and the code shell in the installation guide[#367] teach us audiocraft requires PyTorch 2.1.0,

so I modified the guide a little (2.0.0 -> 2.1.0)

Thank you for your hard work and dedication for sharing and developing interesting project.🙇‍♂️🙇‍♂️

Hope you stay healty and have a Happy Christmas season

@J4BEZ
Edit installation (PyTorch 2.0.0 -> 2.1.0)
f24f3de 
`requiremetns.txt`[facebookresearch#352] and the code shell in the installation guide[facebookresearch#367] teach us audiocraft requires PyTorch 2.1.0,

so I modified the guide a little (2.0.0 -> 2.1.0)

Thank you for your hard work and dedication for sharing and developing interesting project.🙇‍♂️🙇‍♂️

Hope you stay healty and have a Happy Christmas season
@facebook-github-bot
Copy link

Hi @J4BEZ!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 15, 2023
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

JadeCopet
JadeCopet approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@JadeCopet JadeCopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@J4BEZ
Copy link
Contributor Author

J4BEZ commented Dec 22, 2023

@JadeCopet I appreciate for taking the time to review my request and for your hard work🙇‍♂️🙇‍♂️

I hope you stay healthy and have a merry christmas🎄

@JadeCopet JadeCopet merged commit e1f2b18 into facebookresearch:main Dec 22, 2023
3 checks passed
@JadeCopet
Copy link
Contributor

Thank you, have a merry Xmas as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JadeCopet JadeCopet JadeCopet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J4BEZ @facebook-github-bot @JadeCopet