Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spaCy dependency so demo project can run #355

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Update spaCy dependency so demo project can run #355

merged 1 commit into from
Nov 27, 2023

Conversation

jamesonwilliams
Copy link

@jamesonwilliams jamesonwilliams commented Nov 22, 2023

Currently, the musicgen_app.py demo does not run; it fails with the following error:

pydantic.errors.PydanticImportError: pydantic:ConstrainedStr has been removed in V2.

It is possible to resolve this error by upping the spaCy dependency, which is what's bringing in the old version of pydantic.

spaCy 3.6.1+ uses the new Pydantic version: https://github.com/explosion/spaCy/releases/tag/v3.6.1

Note: this PR is similar to #278.

Currently, the musicgen_app.py demo does not run; it fails with the
following error:

> pydantic.errors.PydanticImportError: `pydantic:ConstrainedStr` has been removed in V2.

It is possible to resolve this error by upping the spaCy dependency,
which is what's bringing in the old version of pydantic.

spaCy 3.6.1+ support the new Pydantic version:

https://github.com/explosion/spaCy/releases/tag/v3.6.1
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2023
@felixkreuk felixkreuk merged commit f83babf into facebookresearch:main Nov 27, 2023
3 checks passed
@felixkreuk
Copy link
Contributor

Thanks for the contribution!

@JadeCopet JadeCopet mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants