Fix musigen app memory issue

[Harushii18]

Fixes 2 issues:

• There was a memory issue where models stayed in memory when models were changed. To replicate the issue: when the model was changed from melody to the medium model, the melody model would remain in memory whilst the medium model was also loaded into memory, consuming large amounts of RAM.

• Once someone clicked the submit button, the old temp files were not removed and stayed on disk (until lifetime was reached). Added another function in the filecleaner to remove these files since they cannot be accessed from the UI anyway once someone regenerates their samples.

[facebook-github-bot]

Hi @Harushii18!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[adefossez]

I dont think you can call this delete_all in the context of the public demo so we will not accept this PR as is. We can accept the deletion of the previous model prior to loading the new one though.

I'm not sure why the delete_all would help compared with the previous mechanism that delete the files after some time ?

[Harushii18]

I dont think you can call this delete_all in the context of the public demo so we will not accept this PR as is. We can accept the deletion of the previous model prior to loading the new one though.

I'm not sure why the delete_all would help compared with the previous mechanism that delete the files after some time ?

Thank you for responding! I added that as once someone clicks the submit button again, the temp files can't be accessed from the UI: only unless someone navigates to that directory manually. So just seemed better to remove it.
However you are right, as it does seem like that part would conflict on the public demo since it might remove other peoples' temp files that they are still accessing.

Will remove those parts.

[felixkreuk]

LGTM! Thanks for contributing @Harushii18!