Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename temp->temperature #280

Closed
wants to merge 1 commit into from
Closed

Conversation

0xlws
Copy link
Contributor

@0xlws 0xlws commented Sep 13, 2023

this was done to keep the naming of parameters consistent throughout,
came to my attention when copied the generation params object,
going back eg **unpacking, temp did not exist where i expected temperature, and to not confuse with temp variables.
thanks

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2023
@0xlws
Copy link
Contributor Author

0xlws commented Sep 14, 2023

the github linter gives an error:
audiocraft/modules/conditioners.py:607: error: Argument 1 to "apply_model" has incompatible type "Union[Tensor, Module]"; expected "Union[BagOfModels, Union[Demucs, HDemucs, HTDemucs]]" [arg-type]
demucs commit
but the repos work fine 🤷🏽‍♂️

@JadeCopet
Copy link
Contributor

Thanks i agree that the small difference between temp in the training code and temperature variable in the models may not be desirable however for backward compatibility of our training that relies on dora and to avoid API changes we'd rather not change this.

@JadeCopet JadeCopet closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants