replace uses of suffixes as list-of-two to tuple in DataFrame.merge i…

…nvocations (#182)

Summary:
X-link: facebookincubator/zstrong#978

Pull Request resolved: #182

Differential Revision: D62041393

fbshipit-source-id: 5c032fe5e542b975862e28a9ff1d7c7737e788a6

hta/analyzers/critical_path_analysis.py

@@ -571,7 +571,7 @@ def _get_cuda_runtime_calls_df(self, retain_index: bool = True) -> pd.DataFrame:
                 gpu_kernels[["stream", "index", "pid"]],
                 left_on="index_correlation",
                 right_on="index",
-                suffixes=["", "_kernel"],
+                suffixes=("", "_kernel"),
             )
             .set_index("index")
         ).rename(columns={"pid_kernel": "gpu_kernel"})
@@ -688,7 +688,7 @@ def find_previous_launch(gpu, stream):
                 left_on="previous_launch_id",
                 right_on="launch_id",
                 how="left",
-                suffixes=["", "_launch_event"],
+                suffixes=("", "_launch_event"),
                 # multiple CUDA records can have same previous launch ID, but not vice versa
                 validate="many_to_one",
             )
@@ -771,7 +771,7 @@ def _get_cuda_stream_wait_event_df(self) -> Optional[pd.DataFrame]:
                 gpu_kernels[["stream", "index"]],
                 left_on="index_correlation",
                 right_on="index",
-                suffixes=["", "_kernel"],
+                suffixes=("", "_kernel"),
             )
             .set_index("index")
         )
@@ -805,7 +805,7 @@ def find_next_launch(pid, tid, stream):
                 left_on="next_launch_id",
                 right_on="launch_id",
                 how="left",
-                suffixes=["", "_launch_event"],
+                suffixes=("", "_launch_event"),
             )
 
         pid_tid_streams = (
@@ -929,7 +929,7 @@ def _construct_graph_from_kernels(self) -> None:
                     left_on="wait_on_cuda_event_record_corr_id",
                     right_on="correlation",
                     how="left",
-                    suffixes=["", "_cuda_record"],
+                    suffixes=("", "_cuda_record"),
                 )
                 .fillna(-1)
                 .astype(int)