Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animation compression:draco-animation. #206

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

owilliamailliwo
Copy link

@owilliamailliwo owilliamailliwo commented Jun 8, 2019

Implemented glTF extension "Draco_animation_compression" for animation compression.
Changed the command line options for draco.
"-d/--draco mesh" for enable mesh compression.
"-d/--draco animation" for enable animation compression.
The document will be update later.

If anyone has any questions feel free to email me: [email protected].

@zellski
Copy link
Contributor

zellski commented Jun 8, 2019

This is great, thank you! Will read through the code later today.

Offhand I'd say we might want to quietly preserve the old --draco behaviour, for the sake of not breaking existing pipelines, but make the documented options --draco-mesh and --draco-animation. But I'll have more to say later.

@zellski
Copy link
Contributor

zellski commented Jun 8, 2019

... and I really have to fix the Travis build ...

@owilliamailliwo
Copy link
Author

This is great, thank you! Will read through the code later today.

Offhand I'd say we might want to quietly preserve the old --draco behaviour, for the sake of not breaking existing pipelines, but make the documented options --draco-mesh and --draco-animation. But I'll have more to say later.

I think what you say is reasonable. Let me know if you have any suggestions.
I will modify it according to your suggestions.

BTW,please let me know when the Travis build is ok.

owilliamailliwo added 2 commits June 17, 2019 08:16
@owilliamailliwo
Copy link
Author

owilliamailliwo commented Aug 29, 2019

This is great, thank you! Will read through the code later today.

Offhand I'd say we might want to quietly preserve the old --draco behaviour, for the sake of not breaking existing pipelines, but make the documented options --draco-mesh and --draco-animation. But I'll have more to say later.

Hi, do you have any suggestions?

@zellski
Copy link
Contributor

zellski commented Aug 30, 2019

I’m sorry for my absence. I’m the only maintainer and sometimes my other obligations must take priority. I will try to take a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants