Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Make simplification with TOP more aggressive #1244

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Make simplification with TOP more aggressive #1244

merged 3 commits into from
Oct 24, 2023

Conversation

hermanventer
Copy link
Contributor

@hermanventer hermanventer commented Oct 22, 2023

Description

Make simplification rules involving TOP include typed variables whose values are not known.

Also pick up a new configuration for including Z3.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

./validate.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2023
@hermanventer hermanventer force-pushed the top branch 8 times, most recently from ee86a8a to 56e675d Compare October 23, 2023 17:37
@hermanventer hermanventer force-pushed the top branch 4 times, most recently from 98077ac to c160189 Compare October 24, 2023 00:19
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1244 (660389f) into main (9b2ceeb) will decrease coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #1244   +/-   ##
=====================================
- Coverage     74%     74%   -1%     
=====================================
  Files         23      23           
  Lines      16807   16827   +20     
=====================================
+ Hits       12552   12563   +11     
- Misses      4255    4264    +9     
Files Coverage Δ
checker/src/abstract_value.rs 76% <100%> (-1%) ⬇️
checker/src/body_visitor.rs 84% <100%> (+<1%) ⬆️
checker/src/path.rs 83% <100%> (-1%) ⬇️
checker/src/type_visitor.rs 76% <100%> (+<1%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hermanventer hermanventer merged commit aac396b into main Oct 24, 2023
8 checks passed
@hermanventer hermanventer deleted the top branch October 24, 2023 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants