Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Commit

Permalink
Fix verification post-commit script not working
Browse files Browse the repository at this point in the history
Summary:
See failure here: https://www.internalfb.com/intern/sandcastle/job/22517999082993393/insights?selectedLines=6282-6283-1-1

We need to run with `root` (and also I added an user because I'm nice)

Reviewed By: jailby

Differential Revision: D45825451

fbshipit-source-id: 306fd952d4a37c6f4a8b56ff150049ee3bac32d8
  • Loading branch information
bigfootjon authored and facebook-github-bot committed May 15, 2023
1 parent aa02e3b commit f99b6ad
Showing 1 changed file with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ final class FBShipItFilterSubmoduleChangesetsTest extends ShellTest {
];
}
return (new ShipItChangeset())
->withAuthor(
\SandcastleOpensourceUpdateProjectSHAsCommand::UPDATE_SUBMODULE_AUTHOR,
)
->withAuthor(\OpensourceBot::getCommitAuthorLine())
->withSubject(FBShipItConfig::UPDATE_SUBMODULE_SUBJECT)
->withMessage(
'Updating submodules
Expand Down Expand Up @@ -90,7 +88,7 @@ Reviewed By: nobody',
$merged_changesets = $config_object->mergeSubmoduleChangesets($changesets);
\expect(C\count($merged_changesets))->toEqual(4);
\expect($merged_changesets[0]->getAuthor())->toEqual(
\SandcastleOpensourceUpdateProjectSHAsCommand::UPDATE_SUBMODULE_AUTHOR,
\OpensourceBot::getCommitAuthorLine(),
);
\expect($merged_changesets[0]->getSubject())->toEqual(
FBShipItConfig::UPDATE_SUBMODULE_SUBJECT,
Expand All @@ -114,7 +112,7 @@ Test Plan:',
\expect($merged_changesets[1])->toEqual($changesets[2]);
\expect($merged_changesets[2])->toEqual($changesets[3]);
\expect($merged_changesets[3]->getAuthor())->toEqual(
\SandcastleOpensourceUpdateProjectSHAsCommand::UPDATE_SUBMODULE_AUTHOR,
\OpensourceBot::getCommitAuthorLine(),
);
\expect($merged_changesets[3]->getSubject())->toEqual(
FBShipItConfig::UPDATE_SUBMODULE_SUBJECT,
Expand All @@ -130,9 +128,7 @@ Test Plan:',
public function testMergeSubmoduleChangesetsNoMerge(): void {
$changesets = vec[
(new ShipItChangeset())
->withAuthor(
\SandcastleOpensourceUpdateProjectSHAsCommand::UPDATE_SUBMODULE_AUTHOR,
)
->withAuthor(\OpensourceBot::getCommitAuthorLine())
->withDiffs(vec[
shape('path' => 'dep_a.txt', 'body' => '9'),
shape('path' => 'dep_b.txt', 'body' => '9'),
Expand Down

0 comments on commit f99b6ad

Please sign in to comment.