Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[playground] Bug fix: prevent growing whitespaces in markdown table toggle #7041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[playground] Bug fix: prevent growing whitespaces in markdown table toggle #7041

wants to merge 1 commit into from

Conversation

potatowagon
Copy link
Contributor

Before

Screen.Recording.2025-01-11.at.6.58.29.PM.mov

^ white spaces in table cell growing

After

Screen.Recording.2025-01-11.at.7.03.38.PM.mov

^ num of white spaces remain constant

@vercel Vercel
Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 11:04am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 11:04am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2025
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical - cjs 31.48 KB (0%)
lexical - esm 31.2 KB (0%)
@lexical/rich-text - cjs 40.54 KB (0%)
@lexical/rich-text - esm 33.21 KB (0%)
@lexical/plain-text - cjs 39.06 KB (0%)
@lexical/plain-text - esm 30.37 KB (0%)
@lexical/react - cjs 42.43 KB (0%)
@lexical/react - esm 34.48 KB (0%)

etrepum
etrepum approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why this works but I think the actual bug is that on import mapToTableCells doesn't discard the required space before and after the | delimiter

@potatowagon potatowagon added this pull request to the merge queue Jan 12, 2025
@potatowagon potatowagon removed this pull request from the merge queue due to a manual request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potatowagon @etrepum @facebook-github-bot