Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge TabIndentionPlugin and ListMaxIndentLevelPlugin plugins #7013

Closed
wants to merge 2 commits into from
Closed

Merge TabIndentionPlugin and ListMaxIndentLevelPlugin plugins #7013

wants to merge 2 commits into from

Conversation

fantactuka
Copy link
Contributor

@fantactuka fantactuka commented Jan 2, 2025 •
edited
Loading

  • Adds INDENT_CONTENT_COMMAND optional maxIndent param that handles both list and block indent
  • Adds TabIndentionPlugin support for maxIndent
  • Removes ListMaxIndentLevelPlugin as redundant

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ❌ Failed (Inspect) Jan 6, 2025 3:48pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 3:48pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 31.39 KB (0%)
lexical - esm 31.19 KB (0%)
@lexical/rich-text - cjs 40.47 KB (0%)
@lexical/rich-text - esm 33.12 KB (0%)
@lexical/plain-text - cjs 39.04 KB (0%)
@lexical/plain-text - esm 30.37 KB (0%)
@lexical/react - cjs 42.3 KB (0%)
@lexical/react - esm 34.42 KB (0%)

@fantactuka fantactuka force-pushed the max-indent branch 2 times, most recently from 4807469 to 18dedf3 Compare January 2, 2025 19:12
ivailop7
ivailop7 previously approved these changes Jan 2, 2025
View reviewed changes
etrepum
etrepum reviewed Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that this has at least one consistently failing test

  1) [chromium] › packages/lexical-playground/__tests__/e2e/ListMaxIndentLevel.spec.mjs:34:3 › Nested List › Can only indent until the max depth when list is empty

@fantactuka fantactuka changed the title Add max-indent for INDENT_CONTENT_COMMAND and corresponding plugins Merge TabIndentionPlugin and ListMaxIndentLevelPlugin plugins Jan 6, 2025
@fantactuka
Copy link
Contributor Author

fantactuka commented Jan 6, 2025 •
edited
Loading

Moved max indent logic into intent plugin, should be easier to use vs explicitly passing max indent with every INDENT_CONTENT command. So it's basically merging MaxListIndent plugin into IndentPlugin with adjustments to handle non-list elements as well

@fantactuka fantactuka closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum left review comments

@ivailop7 ivailop7 ivailop7 left review comments

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fantactuka @etrepum @ivailop7 @facebook-github-bot