Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][lexical-table] Feature: Use custom selection behavior for table cell triple click #7005

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP][lexical-table] Feature: Use custom selection behavior for table cell triple click #7005

wants to merge 1 commit into from

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Dec 30, 2024

Description

The native browser triple click over-selects in tables compared to the expectation of selecting the cell. By adding a click handler that looks for detail === 3 we can detect this event and customize the behavior.

TODO:

  • See if it's possible to prevent the native flash of the over-select before it's fixed by this custom handler
  • e2e test

Closes #6973

Test plan

Before

Insert relevant screenshots/recordings/automated-tests

After

Insert relevant screenshots/recordings/automated-tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 30, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 7:14pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 7:14pm

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical - cjs 31.21 KB (0%)
lexical - esm 31.1 KB (0%)
@lexical/rich-text - cjs 40.31 KB (0%)
@lexical/rich-text - esm 33.01 KB (0%)
@lexical/plain-text - cjs 38.85 KB (0%)
@lexical/plain-text - esm 30.22 KB (0%)
@lexical/react - cjs 42.13 KB (0%)
@lexical/react - esm 34.26 KB (0%)

@etrepum etrepum mentioned this pull request Dec 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx will be requested when the pull request is marked ready for review zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka will be requested when the pull request is marked ready for review fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson will be requested when the pull request is marked ready for review acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz will be requested when the pull request is marked ready for review Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 will be requested when the pull request is marked ready for review ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm will be requested when the pull request is marked ready for review Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon will be requested when the pull request is marked ready for review potatowagon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Selection of table cell is accompanied by selection of adjacent cell too
2 participants
@etrepum @facebook-github-bot