Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: expose forEachSelectedTextNode #6981

Merged
merged 29 commits into from
Dec 21, 2024
Merged

feature: expose forEachSelectedTextNode #6981

merged 29 commits into from
Dec 21, 2024
+26 −15

Conversation

GermanJablo
Copy link
Contributor

I'd like to extract this feature from my previous PR as it wasn't the point of that PR and will likely be closed.

I'm basically extracting the logic from $patchStyleText into this new function. Iterating over selected text nodes is not a trivial task, since it has to consider partitioning of partial textNodes or token/segmented texts.

The code for this function is mostly repeated in Selection.formatText (I leave a comment there), and perhaps elsewhere.

GermanJablo and others added 25 commits December 5, 2024 16:18
@GermanJablo
add __classes, getClasses and mutateClasses
6323262
@GermanJablo
amend
7bb7820
@GermanJablo
fix errors
bede9a9
@GermanJablo
fix $canSimpleTextNodesBeMerged and exportDOM
264b87b
@GermanJablo
add test
f290e0c
@GermanJablo
rename $mutateSelectedTextNodes to $forEachSelectedTextNode
b9fa298
@GermanJablo
add docs
0ff2383
@GermanJablo
add tests for exportJSON
10454ee
@GermanJablo
test name
5c554d2
@GermanJablo
spread classes
b6e7525
@GermanJablo
fix updateDOM
38764d4
@GermanJablo
comment typo
a367219
@GermanJablo
remove comment
df4f570
@GermanJablo
replace mutateClasses with setClass
ae2c32a
@GermanJablo
update docs
727d47d
@GermanJablo
revert getClasses, allow empty object classes, move clone logic to af…
00c711e 
…terCloneFrom
@GermanJablo
fix afterCloneFrom
3da33aa
@GermanJablo @etrepum
Update packages/lexical/src/LexicalNode.ts
110e591 
Co-authored-by: Bob Ippolito <[email protected]>
@GermanJablo @etrepum
Update packages/lexical/src/LexicalNode.ts
b96a12e 
Co-authored-by: Bob Ippolito <[email protected]>
@GermanJablo @etrepum
Update packages/lexical/src/LexicalEditorState.ts
a2fb1df 
Co-authored-by: Bob Ippolito <[email protected]>
@GermanJablo
revert doc url name changed
66d0679
@GermanJablo
node.__classes check is actually needed as long as the property is op…
2908b29 
…tional
@GermanJablo
|| {} is actually needed as long as the property is optional
b8e09bb
@GermanJablo
revert || {} is actually needed as long as the property is optional. …
0372f9e 
…I just needed to remove the return type
@GermanJablo
revert unused changes
ba2f11d
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:46pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:46pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 31.29 KB (0%)
lexical - esm 31.11 KB (0%)
@lexical/rich-text - cjs 40.34 KB (0%)
@lexical/rich-text - esm 33.04 KB (0%)
@lexical/plain-text - cjs 38.88 KB (0%)
@lexical/plain-text - esm 30.3 KB (0%)
@lexical/react - cjs 42.12 KB (0%)
@lexical/react - esm 34.29 KB (0%)

etrepum
etrepum reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a very useful thing to expose

packages/lexical-selection/src/lexical-node.ts Show resolved Hide resolved
@GermanJablo
Revert "includeIfCollapsed"
813d61c 
This reverts commit f6407b7.
etrepum
etrepum approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, are you planning to write any additional tests or are we just depending on the $patchStyle tests to verify the behavior here?

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Dec 20, 2024
@GermanJablo
Copy link
Contributor Author

$patchStyle tests seem enough to me. If there is something wrong with forEachSelectedTextNode, it should fail in patchStyles since it is a very basic wrapper.

@etrepum etrepum added this pull request to the merge queue Dec 21, 2024
Merged via the queue into facebook:main with commit e0dafb8 Dec 21, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GermanJablo @etrepum @facebook-github-bot