-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-table][lexical-playground] Fix: Insertion of multiple rows #6963
[lexical-table][lexical-playground] Fix: Insertion of multiple rows #6963
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, nice job! Will merge assuming the extended test suite still looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new test either needs to be skipped with isCollab, or it needs to be fixed for isCollab. The selection classes won't appear on the right frame because that's not the editor they are selected in, so a separate HTML document needs to be specified for the right frame.
When is the release planned that includes above change? |
Releases happen about once a month. If you need it sooner, you can use a nightly release. |
Description
Describe the changes in this pull request
When inserting multiple rows only one row was being added and also the position of the newly added row was sometimes in the middle of the rows.
Fixed the
insertTableRow_Experimental
function to handle the insertAfter and insertBefore row based on the maximum and minimum value of anchor and focus row.Closes #6933
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
multiple_rows_before.1.mp4
After
multiple_rows.1.mp4