[lexical-utils] Bug Fix: Refactor markSelection for getDOMSlot and not using updateDOM #6961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The usage of updateDOM in markSelection seemed to create DOM churn in certain circumstances for CJK composition inputs which affected user input and selection. Refactoring the function to instead use the invariant that if updateDOM did return true, then the identity of the rendered DOM element would've changed.
While I was in there I also refactored the range code to support the getDOMSlot API. We don't currently have any code that offsets the first child, but if we did then we'd have another bug to fix here.
Closes #6947
Closes #6946
Test plan
Should be covered by existing SelectionAlwaysOnDisplay test coverage