Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground] [markdown] Fix: Block math equation is falsely converted to inline equation on MarkdownShortcutPlugin #6948

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[lexical-playground] [markdown] Fix: Block math equation is falsely converted to inline equation on MarkdownShortcutPlugin #6948

wants to merge 3 commits into from
+13 −6

Conversation

vantage-ola
Copy link
Contributor

Closes #6936

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:49pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:49pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 31.29 KB (0%)
lexical - esm 31.11 KB (0%)
@lexical/rich-text - cjs 40.34 KB (0%)
@lexical/rich-text - esm 33.04 KB (0%)
@lexical/plain-text - cjs 38.88 KB (0%)
@lexical/plain-text - esm 30.3 KB (0%)
@lexical/react - cjs 42.12 KB (0%)
@lexical/react - esm 34.29 KB (0%)

@vantage-ola vantage-ola marked this pull request as ready for review December 14, 2024 15:40
@vantage-ola
Copy link
Contributor Author

#6936 (comment) @etrepum

etrepum
etrepum reviewed Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is useful or not, but it certainly doesn't fix the bug reported in #6936

@vantage-ola
Copy link
Contributor Author

vantage-ola commented Dec 18, 2024 •
edited
Loading

as of now, i haven't figured out the regex yet. the behaviour of the lexical playground as of now

Recording.2024-12-18.182216.mp4

@vantage-ola vantage-ola reopened this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum left review comments

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Block math equation is falsely converted to inline equation on MarkdownShortcutPlugin
3 participants
@vantage-ola @etrepum @facebook-github-bot