[lexical-react] Feature: add attributes in LinkPlugin #6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taro-shono
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
|
code lgtm, can we have some tests please to check that attributes are added to link on paste? |
potatowagon
reviewed
Oct 25, 2024
| ...attributes, | ||
| rel, | ||
| target, | ||
| title, |
There was a problem hiding this comment.
this means that the link attribute contents of payload will overwrite the contents of attributes
potatowagon
previously approved these changes
Oct 25, 2024
|
@potatowagon I have added a test, so please check it out. |
potatowagon
previously approved these changes
Oct 25, 2024
potatowagon
approved these changes
Oct 25, 2024
|
thanks for this! |
|
Thanks for the plugin. But if i switch off attributes after link is created - it doesn't removes target="__blank" atribute from node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add attributes when pasting a link into a text.
Test plan
Before
Can not add
targetScreen.Shot.2024-10-25.at.16.18.09.mp4
After
Can add
targetScreen.Shot.2024-10-25.at.16.18.49.mp4