[lexical] Bug Fix: Insertion into inline ElementNode should not crash #6703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
force-pushed
the
inline-elementnode-insertion
branch
from
836be64 to
732f3dd
Compare
etrepum
commented
Oct 5, 2024
| @@ -1732,7 +1732,7 @@ export function INTERNAL_$isBlock( | |||
| export function $getAncestor<NodeType extends LexicalNode = LexicalNode>( | |||
| node: LexicalNode, | |||
| predicate: (ancestor: LexicalNode) => ancestor is NodeType, | |||
| ) { | |||
| ): NodeType | null { | |||
There was a problem hiding this comment.
This is just being a bit more explicit rather than relying on inference, usually it's best practice for exported types to be explicit.
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
ivailop7
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6701
Test plan
Before
Constructing a document where the children of RootNode are inline ElementNode causes a crash on
selection.insertNodes(…)(as in paste) because there is an assumption with no runtime invariant that all children of the root are block nodes.After
A runtime invariant was added to prevent that, and the incorrect type assertions were removed. A unit test is added to cover this particular case.